Plans

Plan Review: Add a docs landing hub

Plan: docs/plans/add-docs-landing-hub.html | Reviewed: 2026-06-07 18:12 UTC | Reviewers: 7 (5 core + 2 UI) | Verdict: Sound with revisions

Executive Summary

The plan is sound with revisions. All seven reviewers agree the scope is appropriate and the architecture is correct for a single-file static HTML change. The team identified several actionable gaps: the smoke test path and naming violated project conventions (tests/pages/test-*), no step created the test files described in the Tests section, the E2E spec assumed Playwright infrastructure that does not exist, the existing test-root-redirect.sh would break silently, the hub page lacked a required skip-link, and card descriptions were too vague. All issues have been addressed in inline edits applied to the source plan.

Role-by-Role Findings

Architecture

Fit: Architecturally sound for scope — single static HTML file, no build pipeline, no external dependencies.

Concerns:

Completeness

Assessment: Well-scoped and largely executable, but had meaningful gaps.

Gaps addressed:

Testability

Coverage: Adequate for the narrow scope after fixes.

Gaps addressed:

Risk

Risk level: Low

Conventions

Fit: Good overall after corrections.

UX

User fit: Clear happy path with direct routing.

Accessibility

A11y compliance: Largely WCAG 2.1 AA compliant after fixes.

Agreements

Skip-link required (Accessibility + UX + Completeness) — the built hub page must include a skip-to-content link.
Test path wrong (Conventions + Completeness + Testability) — smoke test belongs at tests/pages/test-docs-hub.sh.
E2E spec not deliverable (Conventions + Testability + Risk) — Playwright spec should be deferred, not current-scope.
test-root-redirect.sh breaks (Conventions + Risk) — existing test will fail after redirect removal.
Git-diff assertion brittle (Architecture + Testability + Risk) — should be replaced with test -f.

Conflicts

No material conflicts. UX reviewer rated "back-to-home link" as high severity and recommended promoting it to a required step; Architecture and Risk reviewers rated it low. Resolution: kept as Next Steps since it modifies files outside this plan's scope (docs/plans/index.html and docs/media/social/index.html), but the prompt is ready to execute immediately after this plan ships.

Highest-Risk Issues (Resolved)

#IssueSourceResolution
1Missing test-creation stepCompletenessAdded Step 6
2Wrong test path/namingConventionsRenamed throughout
3test-root-redirect.sh breakageConventions + RiskAdded to Files and AC9
4No skip-link on hubAccessibilityAdded to Step 4 and AC8
5E2E spec assumes missing infraConventions + TestabilityDeferred with status note

Edits Applied to Source Plan

TargetActionChange
Files sectioneditRenamed smoke test to tests/pages/test-docs-hub.sh; added tests/pages/test-root-redirect.sh as modified
Step 1 verifyeditAdded HTML boilerplate checks: DOCTYPE, lang, charset, viewport, title, skip-link
Step 3 verifyeditRequired descriptive card subtitles
Step 4editAdded skip-link requirement, tablet-range viewport check (640px–1024px)
Step 5 verifyeditFixed port placeholder to 8123; replaced git-diff with test -f
Steps sectioninsertAdded Step 6: write smoke test and update/delete test-root-redirect.sh
Objective testeditFixed path, naming convention, added CSS token assertion, replaced git-diff
E2E testeditMarked as deferred; added skip-link to key cases
Acceptance CriteriaappendAdded AC8 (skip-link) and AC9 (test-root-redirect.sh updated)
VerificationeditFixed test path, added skip-link check, CDN propagation note
Next StepsinsertAdded Playwright E2E infrastructure setup prompt
Files noteeditAdded E2E spec deferral note to out-of-scope line